Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-09-15 Thread Markus Armbruster
Markus Armbruster writes: > Vladimir Sementsov-Ogievskiy writes: > >> 08.06.2021 14:12, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> >>> [...] >>> TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-09-03 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.05.2021 21:37, John Snow wrote: >> On 5/24/21 10:06 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 15.05.2021 01:38, John Snow wrote: On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: > TODO: We also need to deprecate drive-backup transaction action..

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-09-01 Thread Vladimir Sementsov-Ogievskiy
24.05.2021 21:37, John Snow wrote: On 5/24/21 10:06 AM, Vladimir Sementsov-Ogievskiy wrote: 15.05.2021 01:38, John Snow wrote: On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated'

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-07-05 Thread Vladimir Sementsov-Ogievskiy
09.06.2021 13:49, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 08.06.2021 14:12, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated'

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-06-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 08.06.2021 14:12, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >> [...] >> >>> TODO: We also need to deprecate drive-backup transaction action.. >>> But union members in QAPI doesn't support 'deprecated' feature. I tried >>> to dig

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-06-08 Thread Vladimir Sementsov-Ogievskiy
08.06.2021 14:12, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it?

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-06-08 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: [...] > TODO: We also need to deprecate drive-backup transaction action.. > But union members in QAPI doesn't support 'deprecated' feature. I tried > to dig a bit, but failed :/ Markus, could you please help with it? At > least by advice? There are two

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-24 Thread John Snow
On 5/24/21 10:06 AM, Vladimir Sementsov-Ogievskiy wrote: 15.05.2021 01:38, John Snow wrote: On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-24 Thread Vladimir Sementsov-Ogievskiy
15.05.2021 01:38, John Snow wrote: On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it? At least by

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-14 Thread John Snow
On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it? At least by advice? Oho, I see. OK, I'm not

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-06 Thread Kashyap Chamarthy
On Wed, May 05, 2021 at 04:58:03PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User of drive-backup expects that

[PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-05 Thread Vladimir Sementsov-Ogievskiy
Modern way is using blockdev-add + blockdev-backup, which provides a lot more control on how target is opened. As example of drive-backup problems consider the following: User of drive-backup expects that target will be opened in the same cache and aio mode as source. Corresponding logic is in