Re: [PATCH v4] libxl: adjust handling of libxl_device_nic objects

2021-05-26 Thread Jim Fehlig
On 5/25/21 3:55 PM, Olaf Hering wrote: Am Tue, 25 May 2021 23:40:59 +0200 schrieb Olaf Hering : In case of error the objects are disposed by libxl_domain_config_dispose. I just realized this is not always true, unless this change is applied on top. If libxlMakeNic fails,

Re: [PATCH v4] libxl: adjust handling of libxl_device_nic objects

2021-05-25 Thread Olaf Hering
Am Tue, 25 May 2021 23:40:59 +0200 schrieb Olaf Hering : > In case of error the objects are disposed by libxl_domain_config_dispose. I just realized this is not always true, unless this change is applied on top. If libxlMakeNic fails, libxl_domain_config_dispose can not release anything. With

[PATCH v4] libxl: adjust handling of libxl_device_nic objects

2021-05-25 Thread Olaf Hering
libxl objects are supposed to be initialized and disposed. Adjust libxlMakeNic to use an already initialized object, it is owned by the caller. Adjust libxlMakeNicList to initialize the list of objects, before they are filled by libxlMakeNic. In case of error the objects are disposed by