Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-08-03 Thread Hendrik Schwartke
Thanks for your support Eric! Hendrik On 03.08.2012 01:14, Eric Blake wrote: On 07/25/2012 01:43 AM, Hendrik Schwartke wrote: The access, birth, modification and change times are added to storage volumes and corresponding xml representations. Listing the actual output XML in the commit

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-08-02 Thread Eric Blake
On 07/25/2012 01:43 AM, Hendrik Schwartke wrote: The access, birth, modification and change times are added to storage volumes and corresponding xml representations. Listing the actual output XML in the commit message will help future readers. --- bootstrap.conf|1 +

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-30 Thread Hendrik Schwartke
Hi Eric, could you give me a short feedback on the status of my patch? Thanks Hendrik On 25.07.2012 09:43, Hendrik Schwartke wrote: The access, birth, modification and change times are added to storage volumes and corresponding xml representations. --- bootstrap.conf|1

[libvirt] [PATCH] Added timestamps to storage volumes

2012-07-25 Thread Hendrik Schwartke
The access, birth, modification and change times are added to storage volumes and corresponding xml representations. --- bootstrap.conf|1 + docs/formatstorage.html.in| 16 docs/schemas/storagevol.rng | 34 ++

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-20 Thread Hendrik Schwartke
On 19.07.2012 16:08, Eric Blake wrote: On 07/19/2012 01:13 AM, Hendrik Schwartke wrote: I reconsidered the way timestamps are represented. I think that an event at 100.91 happened before 100.200 is misleading. Yep, definite bug - you have to zero-pad the subsecond resolution, and also consider

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-19 Thread Hendrik Schwartke
I reconsidered the way timestamps are represented. I think that an event at 100.91 happened before 100.200 is misleading. So I changed that. Furthermore I would appreciate if the timestamps are available in 0.10.0, so I splitted the patch. The first patch doesn't use stat-time and the second

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-19 Thread Eric Blake
On 07/19/2012 01:13 AM, Hendrik Schwartke wrote: I reconsidered the way timestamps are represented. I think that an event at 100.91 happened before 100.200 is misleading. Yep, definite bug - you have to zero-pad the subsecond resolution, and also consider whether to strip trailing zeros. So I

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-16 Thread Hendrik Schwartke
On 13.07.2012 17:14, Eric Blake wrote: On 07/13/2012 08:38 AM, Hendrik Schwartke wrote: !!! DON'T PUSH until stat-time lgpl 3 issue is fixed !!! To tests this change lgpl version to 3 in bootstrap.conf:176 The access, birth, modification and change times are added to storage volumes and

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-16 Thread Hendrik Schwartke
On 16.07.2012 09:45, Hendrik Schwartke wrote: On 13.07.2012 17:14, Eric Blake wrote: On 07/13/2012 08:38 AM, Hendrik Schwartke wrote: !!! DON'T PUSH until stat-time lgpl 3 issue is fixed !!! To tests this change lgpl version to 3 in bootstrap.conf:176 The access, birth, modification and

[libvirt] [PATCH] Added timestamps to storage volumes

2012-07-13 Thread Hendrik Schwartke
!!! DON'T PUSH until stat-time lgpl 3 issue is fixed !!! To tests this change lgpl version to 3 in bootstrap.conf:176 The access, birth, modification and change times are added to storage volumes and corresponding xml representations. --- bootstrap.conf|1 +

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-13 Thread Eric Blake
On 07/13/2012 08:38 AM, Hendrik Schwartke wrote: !!! DON'T PUSH until stat-time lgpl 3 issue is fixed !!! To tests this change lgpl version to 3 in bootstrap.conf:176 The access, birth, modification and change times are added to storage volumes and corresponding xml representations. ---

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-11 Thread Hendrik Schwartke
On 10.07.2012 17:36, Eric Blake wrote: On 07/10/2012 09:22 AM, Hendrik Schwartke wrote: The access, modification and change times are added to storage volumes and corresponding xml representations. --- docs/formatstorage.html.in| 13 + docs/schemas/storagevol.rng | 23

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-11 Thread Eric Blake
On 07/11/2012 01:12 AM, Hendrik Schwartke wrote: +atime-tv_sec = sb.st_atime; +mtime-tv_sec = sb.st_mtime; +catime-tv_sec = sb.st_ctime; +#if _BSD_SOURCE || _SVID_SOURCE +atime-tv_nsec = sb.st_atim.tv_nsec; Yuck. I've nearly got consensus to use the gnulib stat-time module,

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-11 Thread Eric Blake
On 07/11/2012 07:09 AM, Eric Blake wrote: On 07/11/2012 01:12 AM, Hendrik Schwartke wrote: +atime-tv_sec = sb.st_atime; +mtime-tv_sec = sb.st_mtime; +catime-tv_sec = sb.st_ctime; +#if _BSD_SOURCE || _SVID_SOURCE +atime-tv_nsec = sb.st_atim.tv_nsec; Yuck. I've nearly got

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-11 Thread Hendrik Schwartke
On 11.07.2012 15:10, Eric Blake wrote: On 07/11/2012 07:09 AM, Eric Blake wrote: On 07/11/2012 01:12 AM, Hendrik Schwartke wrote: +atime-tv_sec = sb.st_atime; +mtime-tv_sec = sb.st_mtime; +catime-tv_sec = sb.st_ctime; +#if _BSD_SOURCE || _SVID_SOURCE +atime-tv_nsec =

[libvirt] [PATCH] Added timestamps to storage volumes

2012-07-10 Thread Hendrik Schwartke
The access, modification and change times are added to storage volumes and corresponding xml representations. --- docs/formatstorage.html.in| 13 + docs/schemas/storagevol.rng | 23 +++ src/conf/storage_conf.c | 12

Re: [libvirt] [PATCH] Added timestamps to storage volumes

2012-07-10 Thread Eric Blake
On 07/10/2012 09:22 AM, Hendrik Schwartke wrote: The access, modification and change times are added to storage volumes and corresponding xml representations. --- docs/formatstorage.html.in| 13 + docs/schemas/storagevol.rng | 23 +++