Hi,
thanks Jamie for this review. All your suggestions make sense to me,
I'll implement + test them and will re-submit as v3.
Cheers,
--
intrigeri
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, 2017-10-26 at 08:39 -0500, Jamie Strandboge wrote:
> On Thu, 2017-10-26 at 10:22 +, intrigeri+libv...@boum.org wrote:
> > diff --git a/examples/apparmor/usr.sbin.libvirtd
> > b/examples/apparmor/usr.sbin.libvirtd
> > index 819068ffc3..eb24726e08 100644
> > ---
On Thu, 2017-10-26 at 10:22 +, intrigeri+libv...@boum.org wrote:
> From: intrigeri
>
> ---
> examples/apparmor/libvirt-qemu | 2 ++
> examples/apparmor/usr.sbin.libvirtd | 6 ++
> 2 files changed, 8 insertions(+)
>
> diff --git
From: intrigeri
---
examples/apparmor/libvirt-qemu | 2 ++
examples/apparmor/usr.sbin.libvirtd | 6 ++
2 files changed, 8 insertions(+)
diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
index b341e31f42..5994a35042 100644
---
intrigeri:
> + network unix dgram,
> + network unix stream,
Hold on, these two rules are probably not needed (chances are that
they were needed due to a bug in the AppArmor parser, that got fixed
in 2.11.1). I'll double-check tomorrow. Sorry for the noise!
--
libvir-list mailing list
---
examples/apparmor/libvirt-qemu | 2 ++
examples/apparmor/usr.sbin.libvirtd | 9 +
2 files changed, 11 insertions(+)
diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
index b341e31f42..5994a35042 100644
--- a/examples/apparmor/libvirt-qemu
+++