Re: [libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils

2017-02-20 Thread Martin Kletzander
On Mon, Feb 20, 2017 at 03:11:37PM +0100, Peter Krempa wrote: On Mon, Feb 20, 2017 at 15:05:33 +0100, Martin Kletzander wrote: On Mon, Feb 20, 2017 at 02:58:49PM +0100, Peter Krempa wrote: > The utils code should stay separated from other code (except for very > well justified cases).

Re: [libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils

2017-02-20 Thread Peter Krempa
On Mon, Feb 20, 2017 at 15:05:33 +0100, Martin Kletzander wrote: > On Mon, Feb 20, 2017 at 02:58:49PM +0100, Peter Krempa wrote: > > The utils code should stay separated from other code (except for very > > well justified cases). Unfortunately commit 272769beccd7479c75e700a6cb > > I honestly

Re: [libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils

2017-02-20 Thread Martin Kletzander
On Mon, Feb 20, 2017 at 02:58:49PM +0100, Peter Krempa wrote: The utils code should stay separated from other code (except for very well justified cases). Unfortunately commit 272769beccd7479c75e700a6cb I honestly don't see the justification for any of these, but ACK for this, hopefully

Re: [libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils

2017-02-20 Thread Jiri Denemark
On Mon, Feb 20, 2017 at 14:58:49 +0100, Peter Krempa wrote: > The utils code should stay separated from other code (except for very > well justified cases). Unfortunately commit 272769beccd7479c75e700a6cb > made it trivial to break the separation (and not get slapped by the > syntax-check rule) by

[libvirt] [PATCH] Disallow inclusion of files from src/conf into src/utils

2017-02-20 Thread Peter Krempa
The utils code should stay separated from other code (except for very well justified cases). Unfortunately commit 272769beccd7479c75e700a6cb made it trivial to break the separation (and not get slapped by the syntax-check rule) by adding -I src/conf to the CFLAGS for utils. Remove this shortcut