Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 03:26:36PM +, Jim Fehlig wrote: > On 7/3/19 2:42 AM, Daniel P. Berrangé wrote: > > On Wed, Jul 03, 2019 at 08:55:15AM +0200, Peter Krempa wrote: > >> On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: > >>> On 03/07/2019 08.03, Peter Krempa wrote: > I'm n

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Jim Fehlig
On 7/3/19 2:42 AM, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2019 at 08:55:15AM +0200, Peter Krempa wrote: >> On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: >>> On 03/07/2019 08.03, Peter Krempa wrote: I'm not sure that this is the right thing to do. virtlogd has some int

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 08:55:15AM +0200, Peter Krempa wrote: > On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: > > On 03/07/2019 08.03, Peter Krempa wrote: > > > I'm not sure that this is the right thing to do. virtlogd has some > > > internal log rotation mechanisms > > > > logrotat

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Jan Zerebecki
On 03/07/2019 08.55, Peter Krempa wrote: > On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: >> On 03/07/2019 08.03, Peter Krempa wrote: >>> I'm not sure that this is the right thing to do. virtlogd has some >>> internal log rotation mechanisms >> >> logrotate is already in use here a

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-02 Thread Peter Krempa
On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: > On 03/07/2019 08.03, Peter Krempa wrote: > > I'm not sure that this is the right thing to do. virtlogd has some > > internal log rotation mechanisms > > logrotate is already in use here and this patch doesn't change what is > rotated n

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-02 Thread Jan Zerebecki
On 03/07/2019 08.03, Peter Krempa wrote: > I'm not sure that this is the right thing to do. virtlogd has some > internal log rotation mechanisms logrotate is already in use here and this patch doesn't change what is rotated nor how often it is rotated. > and also the SIGUSR1 action is reserved >

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-02 Thread Peter Krempa
On Tue, Jul 02, 2019 at 20:24:09 +0200, Jan Zerebecki wrote: > With logrotates copytruncate when e.g. domain1 doesn't exist anymore > /var/log/libvirt/qemu/domain1.log will still exist after rotation even > though it will never be written to. When new domain names keep getting > used this leads to

[libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-02 Thread Jan Zerebecki
With logrotates copytruncate when e.g. domain1 doesn't exist anymore /var/log/libvirt/qemu/domain1.log will still exist after rotation even though it will never be written to. When new domain names keep getting used this leads to a lot of empty logfiles. This may lead to slowdown or lack of free di