Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

2018-08-09 Thread Michal Privoznik
On 08/09/2018 07:15 PM, Jim Fehlig wrote: > > I tested the patch, works fine. What is the best course of action since > I pushed the other one? Revert it and push your patch? No need to revert. I'll send a patch that moves DLOPEN_* where I suggested. Michal -- libvir-list mailing list

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

2018-08-09 Thread Jim Fehlig
On 08/09/2018 07:42 AM, Michal Privoznik wrote: On 08/08/2018 07:00 PM, Jim Fehlig wrote: While local builds succeed fine, a build worker building in a chroot environment is encountering errors when linking some items in tools/nss and tests, e.g. [ 469s] libtool: link: gcc -shared -fPIC

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

2018-08-09 Thread Michal Privoznik
On 08/08/2018 07:00 PM, Jim Fehlig wrote: > While local builds succeed fine, a build worker building in a chroot > environment is encountering errors when linking some items in tools/nss > and tests, e.g. > > [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive >

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

2018-08-08 Thread Daniel P . Berrangé
On Wed, Aug 08, 2018 at 11:00:01AM -0600, Jim Fehlig wrote: > While local builds succeed fine, a build worker building in a chroot > environment is encountering errors when linking some items in tools/nss > and tests, e.g. > > [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive

[libvirt] [PATCH] Fix link errors in tools/nss and tests

2018-08-08 Thread Jim Fehlig
While local builds succeed fine, a build worker building in a chroot environment is encountering errors when linking some items in tools/nss and tests, e.g. [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive nss/.libs/libnss_libvirt_impl.a -Wl,--no-whole-archive -lpthread