Re: [libvirt] [PATCH] Give virNWFilterVarCombIterNext saner semantics

2014-03-19 Thread Stefan Berger
On 03/17/2014 08:34 AM, Daniel P. Berrange wrote: The virNWFilterVarCombIterNext method will free its parameter when it gets to the end of the iterator. This is somewhat misleading design, making it appear as if the caller has a memory leak. Remove the free'ing of the parameter and ensure that

[libvirt] [PATCH] Give virNWFilterVarCombIterNext saner semantics

2014-03-17 Thread Daniel P. Berrange
The virNWFilterVarCombIterNext method will free its parameter when it gets to the end of the iterator. This is somewhat misleading design, making it appear as if the caller has a memory leak. Remove the free'ing of the parameter and ensure that the calling method

Re: [libvirt] [PATCH] Give virNWFilterVarCombIterNext saner semantics

2014-03-17 Thread Martin Kletzander
On Mon, Mar 17, 2014 at 12:34:21PM +, Daniel P. Berrange wrote: The virNWFilterVarCombIterNext method will free its parameter when it gets to the end of the iterator. This is somewhat misleading design, making it appear as if the caller has a memory leak. Remove the free'ing of the

Re: [libvirt] [PATCH] Give virNWFilterVarCombIterNext saner semantics

2014-03-17 Thread Michal Privoznik
On 17.03.2014 13:34, Daniel P. Berrange wrote: The virNWFilterVarCombIterNext method will free its parameter when it gets to the end of the iterator. This is somewhat misleading design, making it appear as if the caller has a memory leak. Remove the free'ing of the parameter and ensure that the