Re: [libvirt] [PATCH] Host cpu offline/online removes the cpus available for vms

2014-02-04 Thread Shivaprasad bhat
Hi Eric, Came across a thread where the kernel stands not to change the cpuset's behavior during the online-offline-online scenario. https://lkml.org/lkml/2012/5/4/265 Hope fixing this in Libvirt makes more sense now. Regards, Shivaprasad G Bhat On Sat, Feb 1, 2014 at 8:49 AM, Shivaprasad

[libvirt] [PATCH] Host cpu offline/online removes the cpus available for vms

2014-01-31 Thread Shivaprasad G Bhat
Online/Offline operations on the host cpus removes the machine/cpuset.cpus which are never added back. The guests with vcpu pinning can fail to boot unless the xml is edited. If the possibility that the offlined cpus are onlined back, the cpuset.cpus can be updated upon start of the guest thus

Re: [libvirt] [PATCH] Host cpu offline/online removes the cpus available for vms

2014-01-31 Thread Eric Blake
On 01/31/2014 12:22 AM, Shivaprasad G Bhat wrote: Online/Offline operations on the host cpus removes the machine/cpuset.cpus which are never added back. The guests with vcpu pinning can fail to boot unless the xml is edited. If the possibility that the offlined cpus are onlined back, the

Re: [libvirt] [PATCH] Host cpu offline/online removes the cpus available for vms

2014-01-31 Thread Shivaprasad bhat
Thanks for the comments Eric. The offline, removes the entry from the cgroups and all its subcgroups. On Online, I guess kernel does not know till which sub-cgroup it should add the entry. I think that is how cgroup is designed to behave when it lacks the policy knowledge. Let me know what you