Re: [libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-26 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 05:49:12PM -0800, john.le...@sun.com wrote: +/* + * If it's not running, we can't help. + */ +if (domain-id 0) +return NULL; NACK. Unfortunately you shouldn't return from a function without setting an error (and you have to set an error

Re: [libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-26 Thread John Levon
On Mon, Jan 26, 2009 at 10:54:23AM +, Richard W.M. Jones wrote: On Thu, Jan 22, 2009 at 05:49:12PM -0800, john.le...@sun.com wrote: +/* + * If it's not running, we can't help. + */ +if (domain-id 0) +return NULL; NACK. Unfortunately you shouldn't return

[libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain

2009-01-22 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1232675291 28800 # Node ID 3ef027308b88b47b2f3ca721bf88f2e606d8e3bc # Parent 903a29e99c80a35ce7f4754a3bcc3ab34bf32d8a Quieten virsh schedinfo for shutoff domain Quietly return failure for a shutoff domain in the sched params driver routines.