Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-11 Thread Daniel P. Berrange
On Wed, Jul 10, 2013 at 07:22:11PM +0200, Martin Kletzander wrote: On 07/10/2013 04:03 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 03:51:45PM +0200, Martin Kletzander wrote: On 07/10/2013 02:39 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin

Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-11 Thread Martin Kletzander
On 07/11/2013 11:47 AM, Daniel P. Berrange wrote: [...] Huh, that doesn't make any sense. The 'alias' data is not user specified. If they attempt to set it in the XML, it'll be dropped by the parser. The alias names are assigned by the QEMU driver unconditionally and unless that code is broken

[libvirt] [PATCH] Reject duplicate disk targets

2013-07-10 Thread Martin Kletzander
We never check for disks with duplicate targets connected to the same controller/bus/etc. That means we go ahead, create the same IDs for them and pass them to qemu, which subsequently fails to start. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=968899 Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-10 Thread Daniel P. Berrange
On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote: We never check for disks with duplicate targets connected to the same controller/bus/etc. That means we go ahead, create the same IDs for them and pass them to qemu, which subsequently fails to start. Resolves:

Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-10 Thread Martin Kletzander
On 07/10/2013 02:39 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote: We never check for disks with duplicate targets connected to the same controller/bus/etc. That means we go ahead, create the same IDs for them and pass them to qemu, which

Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-10 Thread Daniel P. Berrange
On Wed, Jul 10, 2013 at 03:51:45PM +0200, Martin Kletzander wrote: On 07/10/2013 02:39 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote: We never check for disks with duplicate targets connected to the same controller/bus/etc. That means we go

Re: [libvirt] [PATCH] Reject duplicate disk targets

2013-07-10 Thread Martin Kletzander
On 07/10/2013 04:03 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 03:51:45PM +0200, Martin Kletzander wrote: On 07/10/2013 02:39 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote: We never check for disks with duplicate targets connected to