Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-23 Thread Claudio Bley
At Tue, 22 Oct 2013 23:09:20 +0100, Martin Kletzander wrote: On Tue, Oct 22, 2013 at 09:52:30PM +0100, Eric Blake wrote: On 10/22/2013 05:19 PM, Martin Kletzander wrote: On RHEL 5, make syntax-check was failing because even strings like 'int isTempChain' matched the 'int i' rule. To be

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-23 Thread Eric Blake
On 10/23/2013 09:33 AM, Claudio Bley wrote: Seems \s is buggy in this grep version with a non UTF-8 locale setting. Observe: $ LANG=en_US.UTF-8 grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)' src/conf/interface_conf.h $ LANG=C grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)'

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-23 Thread Claudio Bley
At Wed, 23 Oct 2013 10:46:46 +0100, Eric Blake wrote: On 10/23/2013 09:33 AM, Claudio Bley wrote: Seems \s is buggy in this grep version with a non UTF-8 locale setting. Observe: $ LANG=en_US.UTF-8 grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)' src/conf/interface_conf.h $

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-23 Thread Eric Blake
On 10/23/2013 11:02 AM, Claudio Bley wrote: Seems \s is buggy in this grep version with a non UTF-8 locale setting. Observe: $ LANG=en_US.UTF-8 grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)' src/conf/interface_conf.h $ LANG=C grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)'

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-23 Thread Claudio Bley
At Wed, 23 Oct 2013 11:08:48 +0100, Eric Blake wrote: On 10/23/2013 11:02 AM, Claudio Bley wrote: Seems \s is buggy in this grep version with a non UTF-8 locale setting. Observe: $ LANG=en_US.UTF-8 grep -nE '\(int|unsigned) ([^(]* )*(i|j|k)(\s|,|;)' src/conf/interface_conf.h $

[libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-22 Thread Martin Kletzander
On RHEL 5, make syntax-check was failing because even strings like 'int isTempChain' matched the 'int i' rule. To be honest, I haven't found the root cause, but the change added makes it work as expected and keeps the proper behavior on newer systems as well. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-22 Thread Eric Blake
On 10/22/2013 05:19 PM, Martin Kletzander wrote: On RHEL 5, make syntax-check was failing because even strings like 'int isTempChain' matched the 'int i' rule. To be honest, I haven't found the root cause, but the change added makes it work as expected and keeps the proper behavior on newer

Re: [libvirt] [PATCH] build: Fix prohibit_int_ijk (and iijjkk) on RHEL 5

2013-10-22 Thread Martin Kletzander
On Tue, Oct 22, 2013 at 09:52:30PM +0100, Eric Blake wrote: On 10/22/2013 05:19 PM, Martin Kletzander wrote: On RHEL 5, make syntax-check was failing because even strings like 'int isTempChain' matched the 'int i' rule. To be honest, I haven't found the root cause, but the change added