Re: [libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-21 Thread Peter Krempa
On Thu, May 21, 2015 at 13:08:12 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in the xml, sysinfo in xml will be lost. Because we forgot restore ctxt-node to the oldnode after parse memory device, this will make the parse function

Re: [libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-21 Thread lhuang
On 05/21/2015 03:46 PM, Peter Krempa wrote: On Thu, May 21, 2015 at 13:08:12 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in the xml, sysinfo in xml will be lost. Because we forgot restore ctxt-node to the oldnode after parse memory

Re: [libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2015 at 05:52:01PM +0800, lhuang wrote: On 05/21/2015 03:46 PM, Peter Krempa wrote: On Thu, May 21, 2015 at 13:08:12 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in the xml, sysinfo in xml will be lost. Because we

Re: [libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-21 Thread lhuang
On 05/21/2015 06:14 PM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 05:52:01PM +0800, lhuang wrote: On 05/21/2015 03:46 PM, Peter Krempa wrote: On Thu, May 21, 2015 at 13:08:12 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in

[libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-20 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in the xml, sysinfo in xml will be lost. Because we forgot restore ctxt-node to the oldnode after parse memory device, this will make the parse function after virDomainMemoryDefParseXML cannot find a node they need when