Re: [libvirt] [PATCH] conf: fix virtType FromString check

2018-07-26 Thread Daniel P . Berrangé
On Thu, Jul 26, 2018 at 11:30:07AM -0400, Cole Robinson wrote: > In the domain definition, virtType is virDomainVirtType which is > unsigned, so comparing against -1 doesn't work. Cast to int first > > Fixes 8e2982b5767 > > Signed-off-by: Cole Robinson > --- > This regressed in the past as

[libvirt] [PATCH] conf: fix virtType FromString check

2018-07-26 Thread Cole Robinson
In the domain definition, virtType is virDomainVirtType which is unsigned, so comparing against -1 doesn't work. Cast to int first Fixes 8e2982b5767 Signed-off-by: Cole Robinson --- This regressed in the past as well, when virtType was changed to virDomainVirtType in 7383b8cc068, fixed by the