Re: [libvirt] [PATCH] conf: forbid negative values in virDomainParseScaledValue

2014-10-30 Thread Martin Kletzander
On Wed, Oct 29, 2014 at 04:18:42PM -0600, Eric Blake wrote: On 10/29/2014 10:35 AM, Martin Kletzander wrote: It makes sense for none of the callers to have negative value as an output and, fortunately, if anyone tried defining domain with negative memory or any other value parsed by

[libvirt] [PATCH] conf: forbid negative values in virDomainParseScaledValue

2014-10-29 Thread Martin Kletzander
It makes sense for none of the callers to have negative value as an output and, fortunately, if anyone tried defining domain with negative memory or any other value parsed by virDomainParseScaledValue(), the resulting value was 0. That means we can error out during parsing as it won't break

Re: [libvirt] [PATCH] conf: forbid negative values in virDomainParseScaledValue

2014-10-29 Thread Eric Blake
On 10/29/2014 10:35 AM, Martin Kletzander wrote: It makes sense for none of the callers to have negative value as an output and, fortunately, if anyone tried defining domain with negative memory or any other value parsed by virDomainParseScaledValue(), the resulting value was 0. That means we