Re: [libvirt] [PATCH] hooks: let virCommand do the error reporting

2012-10-09 Thread Martin Kletzander
On 10/09/2012 05:47 AM, Eric Blake wrote: The code was reporting raw exit status without decoding it into normal vs. signal exit. virCommandRun already does this, but with a different error type, so all we have to do is recast the error to the correct type. Reported by li guang. *

Re: [libvirt] [PATCH] hooks: let virCommand do the error reporting

2012-10-09 Thread Eric Blake
On 10/09/2012 12:32 AM, Martin Kletzander wrote: On 10/09/2012 05:47 AM, Eric Blake wrote: The code was reporting raw exit status without decoding it into normal vs. signal exit. virCommandRun already does this, but with a different error type, so all we have to do is recast the error to the

Re: [libvirt] [PATCH] hooks: let virCommand do the error reporting

2012-10-09 Thread Martin Kletzander
On 10/09/2012 04:45 PM, Eric Blake wrote: On 10/09/2012 12:32 AM, Martin Kletzander wrote: On 10/09/2012 05:47 AM, Eric Blake wrote: The code was reporting raw exit status without decoding it into normal vs. signal exit. virCommandRun already does this, but with a different error type, so

[libvirt] [PATCH] hooks: let virCommand do the error reporting

2012-10-08 Thread Eric Blake
The code was reporting raw exit status without decoding it into normal vs. signal exit. virCommandRun already does this, but with a different error type, so all we have to do is recast the error to the correct type. Reported by li guang. * src/util/hooks.c (virHookCall): Simplify. --- In