Re: [libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 11:25:36AM +0200, Michal Privoznik wrote: > Firstly, virCommandRun() does report an error on failure (which > in most cases is more accurate than what we overwrite it with). > Secondly, usually errno is not set (or gets overwritten in the > cleanup code) which makes

[libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails

2019-04-12 Thread Michal Privoznik
Firstly, virCommandRun() does report an error on failure (which in most cases is more accurate than what we overwrite it with). Secondly, usually errno is not set (or gets overwritten in the cleanup code) which makes virReportSystemError() report useless error messages. Drop all