Re: [libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

2016-10-11 Thread Nitesh Konkar
Hello Daniel, Thanks for the feedback . Actually I only line wrapped those lines exceeding 80 column limit. Rest I left unchanged. I particularly sent this patch to get feedback on whether its a rule or not as HACKING file hints at it and patch reviews point at it. Anywaz it does not make any

Re: [libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

2016-10-05 Thread Andrea Bolognani
On Wed, 2016-09-28 at 10:04 +0100, Daniel P. Berrange wrote: > We do *not* apply > a strict 80 character limit in libvirt. Is that so? I was under the impression that we did, mostly due to the fact that long lines are often pointed out during review, but turns out that in fact the HACKING file

Re: [libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

2016-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2016 at 12:27:21AM +0530, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/libvirt-storage.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/src/libvirt-storage.c

[libvirt] [PATCH] libvirt-storage.c:Lines too long, use 80 character columns.

2016-09-27 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- src/libvirt-storage.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 48996ba..c4f2a03 100644 --- a/src/libvirt-storage.c +++