Re: [libvirt] [PATCH] libxl: fix leaking of allocated migration ports

2016-10-24 Thread Jim Fehlig
On 10/21/2016 04:41 AM, Pavel Hrdina wrote: > On Fri, Oct 14, 2016 at 12:19:19PM -0600, Jim Fehlig wrote: >> Although the migration port is immediately released in the >> finish phase of migration, it was never set in the domain >> private object when allocated in the prepare phase. So >>

Re: [libvirt] [PATCH] libxl: fix leaking of allocated migration ports

2016-10-21 Thread Pavel Hrdina
On Fri, Oct 14, 2016 at 12:19:19PM -0600, Jim Fehlig wrote: > Although the migration port is immediately released in the > finish phase of migration, it was never set in the domain > private object when allocated in the prepare phase. So > libxlDomainMigrationFinish() always released a

[libvirt] [PATCH] libxl: fix leaking of allocated migration ports

2016-10-14 Thread Jim Fehlig
Although the migration port is immediately released in the finish phase of migration, it was never set in the domain private object when allocated in the prepare phase. So libxlDomainMigrationFinish() always released a 0-initialized migrationPort, leaking any allocated port. After enough