Re: [libvirt] [PATCH] lxc: Correctly report active cgroups

2012-10-02 Thread Michal Privoznik
On 01.10.2012 15:12, Martin Kletzander wrote: On 10/01/2012 02:54 PM, Michal Privoznik wrote: There was an inverted return value in lxcCgroupControllerActive(). The function assumes cgroups are active and do couple of checks to prove that. If any of them fails, false is returned. Therefore,

[libvirt] [PATCH] lxc: Correctly report active cgroups

2012-10-01 Thread Michal Privoznik
There was an inverted return value in lxcCgroupControllerActive(). The function assumes cgroups are active and do couple of checks to prove that. If any of them fails, false is returned. Therefore, at the end, after all checks are done we must return true, not false. --- src/lxc/lxc_driver.c |

Re: [libvirt] [PATCH] lxc: Correctly report active cgroups

2012-10-01 Thread Martin Kletzander
On 10/01/2012 02:54 PM, Michal Privoznik wrote: There was an inverted return value in lxcCgroupControllerActive(). The function assumes cgroups are active and do couple of checks to prove that. If any of them fails, false is returned. Therefore, at the end, after all checks are done we must