Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-27 Thread Roopa Prabhu
On 10/26/11 8:01 PM, Roopa Prabhu ropra...@cisco.com wrote: On 10/24/11 11:14 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote: On 10/20/2011 01:46 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-27 Thread Eric Blake
On 10/27/2011 05:57 PM, Roopa Prabhu wrote: Also, looks like no where else in libvirt code we return errno. We only print errno but always return -1. And the -ETIMEDOUT case in macvtap is an exception, cause the upper layer requires the cause of this particular error. We have a few places

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-27 Thread Roopa Prabhu
On 10/27/11 7:01 PM, Eric Blake ebl...@redhat.com wrote: On 10/27/2011 05:57 PM, Roopa Prabhu wrote: Also, looks like no where else in libvirt code we return errno. We only print errno but always return -1. And the -ETIMEDOUT case in macvtap is an exception, cause the upper layer

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-24 Thread Stefan Berger
On 10/20/2011 01:46 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is initialized to. Can be fixed as a separate patch if needed.

[libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Roopa Prabhu
From: Roopa Prabhu ropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is initialized to. Can be fixed as a separate patch if needed. The scope of this patch is just to fix the

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Srivatsa S. Bhat
On 10/20/2011 10:42 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is initialized to. Can be fixed as a separate patch if

[libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Roopa Prabhu
From: Roopa Prabhu ropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is initialized to. Can be fixed as a separate patch if needed. The scope of this patch is just to fix the

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Roopa Prabhu
On 10/20/11 10:22 AM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 10/20/2011 10:42 PM, Roopa Prabhu wrote: From: Roopa Prabhu ropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Laine Stump
On 10/20/2011 01:46 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is initialized to. Can be fixed as a separate patch if needed.

Re: [libvirt] [PATCH] macvtap: Fix error return values to -1 instead of 1

2011-10-20 Thread Roopa Prabhu
On 10/20/11 11:57 AM, Laine Stump la...@laine.org wrote: On 10/20/2011 01:46 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com Fixes some cases where 1 was being returned instead of -1. There are still some inconsistencies in the file with respect to what the return variable is