[libvirt] [PATCH] network: Fix dnsmasq hostsfile creation logic and related tests

2011-06-28 Thread Matthias Bolte
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010). It has a force flag. If the dnsmasq hostsfile already exists force needs to be true to overwrite it. networkBuildDnsmasqArgv sets force to false, networkDefine sets it to true. This results in the hostsfile being written only in

Re: [libvirt] [PATCH] network: Fix dnsmasq hostsfile creation logic and related tests

2011-06-28 Thread Eric Blake
On 06/28/2011 05:10 AM, Matthias Bolte wrote: networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010). It has a force flag. If the dnsmasq hostsfile already exists force needs to be true to overwrite it. networkBuildDnsmasqArgv sets force to false, networkDefine sets it to true. This

Re: [libvirt] [PATCH] network: Fix dnsmasq hostsfile creation logic and related tests

2011-06-28 Thread Michal Novotny
On 06/28/2011 01:10 PM, Matthias Bolte wrote: networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010). It has a force flag. If the dnsmasq hostsfile already exists force needs to be true to overwrite it. networkBuildDnsmasqArgv sets force to false, networkDefine sets it to true. This

Re: [libvirt] [PATCH] network: Fix dnsmasq hostsfile creation logic and related tests

2011-06-28 Thread Matthias Bolte
2011/6/28 Eric Blake ebl...@redhat.com: On 06/28/2011 05:10 AM, Matthias Bolte wrote: networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010). It has a force flag. If the dnsmasq hostsfile already exists force needs to be true to overwrite it. networkBuildDnsmasqArgv sets force to