Re: [libvirt] [PATCH] network: check negative values in bridge queues

2014-09-16 Thread Erik Skultety
Thanks for review. Erik On 09/15/2014 05:51 PM, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 05:41:38PM +0200, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 05:34:36PM +0200, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote: We already are checkin

Re: [libvirt] [PATCH] network: check negative values in bridge queues

2014-09-15 Thread Martin Kletzander
On Mon, Sep 15, 2014 at 05:41:38PM +0200, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 05:34:36PM +0200, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote: We already are checking for negative value, reporting an error, but using wrong function, so the c

Re: [libvirt] [PATCH] network: check negative values in bridge queues

2014-09-15 Thread Martin Kletzander
On Mon, Sep 15, 2014 at 05:34:36PM +0200, Martin Kletzander wrote: On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote: We already are checking for negative value, reporting an error, but using wrong function, so the check never succeeds. This patch provides Actually it could succeed

Re: [libvirt] [PATCH] network: check negative values in bridge queues

2014-09-15 Thread Martin Kletzander
On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote: We already are checking for negative value, reporting an error, but using wrong function, so the check never succeeds. This patch provides Actually it could succeed, for example with queues="asdf" or "3d" it would return a -1. So I

[libvirt] [PATCH] network: check negative values in bridge queues

2014-09-15 Thread Erik Skultety
We already are checking for negative value, reporting an error, but using wrong function, so the check never succeeds. This patch provides just a minor change in call of the right version of function virStrToLong. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138539 --- src/conf/domain_c