Re: [libvirt] [PATCH] network: restrict usage of port management APIs

2018-08-09 Thread Daniel P . Berrangé
On Thu, Aug 09, 2018 at 11:54:42AM -0400, Laine Stump wrote: > On 08/09/2018 03:58 AM, Daniel P. Berrangé wrote: > > On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote: > >> On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote: > >>> The port allocation APIs are currently called

Re: [libvirt] [PATCH] network: restrict usage of port management APIs

2018-08-09 Thread Laine Stump
On 08/09/2018 03:58 AM, Daniel P. Berrangé wrote: > On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote: >> On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote: >>> The port allocation APIs are currently called unconditionally for all >>> types of NIC, but (mostly) only do anything for NICs

Re: [libvirt] [PATCH] network: restrict usage of port management APIs

2018-08-09 Thread Daniel P . Berrangé
On Wed, Aug 08, 2018 at 11:41:23PM -0400, Laine Stump wrote: > On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote: > > The port allocation APIs are currently called unconditionally for all > > types of NIC, but (mostly) only do anything for NICs with type=network. > > > > The exception is the port

Re: [libvirt] [PATCH] network: restrict usage of port management APIs

2018-08-08 Thread Laine Stump
On 08/08/2018 11:46 AM, Daniel P. Berrangé wrote: > The port allocation APIs are currently called unconditionally for all > types of NIC, but (mostly) only do anything for NICs with type=network. > > The exception is the port allocate API which does some validation even > for NICs with

[libvirt] [PATCH] network: restrict usage of port management APIs

2018-08-08 Thread Daniel P . Berrangé
The port allocation APIs are currently called unconditionally for all types of NIC, but (mostly) only do anything for NICs with type=network. The exception is the port allocate API which does some validation even for NICs with type!=network. Relying on this validation is flawed, however, since