The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete' option.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1001475
Signed-off-by: Alex
On 08/27/13 09:53, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by
qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete'
option.
RHBZ:
On 08/27/2013 04:47 PM, Peter Krempa wrote:
On 08/27/13 09:53, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete' option.
On 27.08.2013 10:58, Alex Jia wrote:
On 08/27/2013 04:47 PM, Peter Krempa wrote:
On 08/27/13 09:53, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by
qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run
On 08/27/13 11:37, Michal Privoznik wrote:
On 27.08.2013 10:58, Alex Jia wrote:
On 08/27/2013 04:47 PM, Peter Krempa wrote:
On 08/27/13 09:53, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by
qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in
On 08/27/2013 01:53 AM, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by
qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete'
option.
RHBZ:
On 08/27/2013 03:37 AM, Michal Privoznik wrote:
Yes, the codes haven't any implementation for BLOCK_COMMIT_DELETE flag
now, maybe, only need to raise a friendly error message in here instead
of unsupported flags (0x2) .
I agree that this error message is not user-friendly. Bare virsh
On 08/27/2013 07:59 PM, Eric Blake wrote:
On 08/27/2013 03:37 AM, Michal Privoznik wrote:
Yes, the codes haven't any implementation for BLOCK_COMMIT_DELETE flag
now, maybe, only need to raise a friendly error message in here instead
of unsupported flags (0x2) .
I agree that this error