Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 03:54:26PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: > This does not cause a problem in usual scenarios thanks to us allowing > CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be > an issue because the directory is created with mkdtemp(3) which explicitly

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 02:45:32PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
On Fri, Apr 12, 2019 at 02:45:32PM +0100, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue

Re: [libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 03:32:21PM +0200, Martin Kletzander wrote: > This does not cause a problem in usual scenarios thanks to us allowing > CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be > an issue because the directory is created with mkdtemp(3) which explicitly

[libvirt] [PATCH] qemu: Label uniqDir when probing capabilities

2019-04-12 Thread Martin Kletzander
This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue because the directory is created with mkdtemp(3) which explicitly creates that with 0700 permissions and qemu running as non-root cannot