Re: [libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread Erik Skultety
On Mon, Sep 02, 2019 at 04:13:55PM +0200, Peter Krempa wrote: > A specially crafted XML which would reference a non-existing disk but > request the mirror to be registered with the blockjob could potentially > make the parser dereference NULL. Fix it by moving the code slightly and > just treat it

Re: [libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread John Ferlan
On 9/2/19 10:13 AM, Peter Krempa wrote: > A specially crafted XML which would reference a non-existing disk but > request the mirror to be registered with the blockjob could potentially > make the parser dereference NULL. Fix it by moving the code slightly and > just treat it as a wrong job

[libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread Peter Krempa
A specially crafted XML which would reference a non-existing disk but request the mirror to be registered with the blockjob could potentially make the parser dereference NULL. Fix it by moving the code slightly and just treat it as a wrong job XML. Found by Coverity. Reported-by: John Ferlan