Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-08 Thread Andrea Bolognani
On Wed, 2018-08-08 at 10:19 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 08, 2018 at 10:12:59AM +0200, Andrea Bolognani wrote: > > On Tue, 2018-08-07 at 16:01 +0100, Daniel P. Berrangé wrote: > > > Someone could build a QEMU with the "pc" machine type deleted entirely, > > > in which case

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-08 Thread Daniel P . Berrangé
On Wed, Aug 08, 2018 at 10:12:59AM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-07 at 16:01 +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 07, 2018 at 04:57:28PM +0200, Andrea Bolognani wrote: > > > > > I wonder if we shouldn't just drop the default machine type handling > > > > > altogether

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-08 Thread Andrea Bolognani
On Tue, 2018-08-07 at 16:01 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 07, 2018 at 04:57:28PM +0200, Andrea Bolognani wrote: > > > > I wonder if we shouldn't just drop the default machine type handling > > > > altogether at this point, though. > > > > > > That's impossible as it violates the

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-07 Thread Daniel P . Berrangé
On Tue, Aug 07, 2018 at 04:57:28PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-07 at 15:28 +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 07, 2018 at 03:54:06PM +0200, Andrea Bolognani wrote: > > > I wonder if we shouldn't just drop the default machine type handling > > > altogether at this

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-07 Thread Andrea Bolognani
On Tue, 2018-08-07 at 15:28 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 07, 2018 at 03:54:06PM +0200, Andrea Bolognani wrote: > > I wonder if we shouldn't just drop the default machine type handling > > altogether at this point, though. > > That's impossible as it violates the back

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-07 Thread Daniel P . Berrangé
On Tue, Aug 07, 2018 at 03:54:06PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-07 at 13:22 +0100, Daniel P. Berrangé wrote: > [...] > > + * Our preferred pmachine might have been compiled out of > > s/pmachine/machine/ > > > + * QEMU at build time though, so we still fallback to

Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-07 Thread Andrea Bolognani
On Tue, 2018-08-07 at 13:22 +0100, Daniel P. Berrangé wrote: [...] > +/* Historically QEMU x86 targets defaulted to 'pc' machine type but > + * in future x86_64 might switch 'q35'. Such a change is considered s/switch/switch to/ > + * an ABI break from libvirt's POV. Other QEMU targets may not

[libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

2018-08-07 Thread Daniel P . Berrangé
It is increasingly likely that some distro is going to change the default "x86" machine type in QEMU from "pc" to "q35". This will certainly break existing applications which write their XML on the assumption that it is using a "pc" machine by default. For example they'll lack a IDE CDROM and get