Re: [libvirt] [PATCH] qemuBuildCommandLine: Don't add tlsPort if none set

2012-03-12 Thread Jiri Denemark
On Thu, Mar 08, 2012 at 14:30:05 +0100, Michal Privoznik wrote: If user hasn't supplied any tlsPort we default to setting it to zero in our internal structure. However, when building command line we test it against -1 which is obviously wrong. --- src/qemu/qemu_command.c |2 +- 1 files

Re: [libvirt] [PATCH] qemuBuildCommandLine: Don't add tlsPort if none set

2012-03-12 Thread Daniel P. Berrange
On Mon, Mar 12, 2012 at 02:21:48PM +0100, Jiri Denemark wrote: On Thu, Mar 08, 2012 at 14:30:05 +0100, Michal Privoznik wrote: If user hasn't supplied any tlsPort we default to setting it to zero in our internal structure. However, when building command line we test it against -1 which is

Re: [libvirt] [PATCH] qemuBuildCommandLine: Don't add tlsPort if none set

2012-03-09 Thread Michal Privoznik
On 08.03.2012 23:26, Eric Blake wrote: On 03/08/2012 06:30 AM, Michal Privoznik wrote: If user hasn't supplied any tlsPort we default to setting it to zero in our internal structure. However, when building command line we test it against -1 which is obviously wrong. ---

[libvirt] [PATCH] qemuBuildCommandLine: Don't add tlsPort if none set

2012-03-08 Thread Michal Privoznik
If user hasn't supplied any tlsPort we default to setting it to zero in our internal structure. However, when building command line we test it against -1 which is obviously wrong. --- src/qemu/qemu_command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] qemuBuildCommandLine: Don't add tlsPort if none set

2012-03-08 Thread Eric Blake
On 03/08/2012 06:30 AM, Michal Privoznik wrote: If user hasn't supplied any tlsPort we default to setting it to zero in our internal structure. However, when building command line we test it against -1 which is obviously wrong. --- src/qemu/qemu_command.c |2 +- 1 files changed, 1