Re: [libvirt] [PATCH] sheepdog: allow snapshot

2016-10-12 5:19 GMT+03:00 Michal Privoznik : > Unfortunately, I don't have a setup to try this out. The code looks > okay, however the commit you are referring to says that there might be > some problems with storing memory into RBD image. So is that the case? > Because if it

Re: [libvirt] [PATCH] sheepdog: allow snapshot

On 11.10.2016 19:30, Vasiliy Tolstov wrote: > 2016-09-29 16:00 GMT+03:00 Vasiliy Tolstov : >> partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because >> sheepdog allow to store vm state inside vdi >> > > Sorry, can somebody check this? > >> Signed-off-by: Vasiliy

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2016-09-29 16:00 GMT+03:00 Vasiliy Tolstov : > partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because > sheepdog allow to store vm state inside vdi > Sorry, can somebody check this? > Signed-off-by: Vasiliy Tolstov > --- >

[libvirt] [PATCH] sheepdog: allow snapshot

partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because sheepdog allow to store vm state inside vdi Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2015-11-30 13:45 GMT+03:00 Vasiliy Tolstov : > In commit f7c1410b0ee5b878e81f2eddf86c609947a9b27c libvirt devs > disable creating snapshot with sheepdog storage and raw image format. > This patch allows creating snapshot (without --live flag for now) > > Vasiliy Tolstov (1): >

[libvirt] [PATCH] sheepdog: allow snapshot

partially revert f7c1410b0ee5b878e81f2eddf86c609947a9b27c because sheepdog allow to store vm state inside vdi Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH] sheepdog: allow snapshot

In commit f7c1410b0ee5b878e81f2eddf86c609947a9b27c libvirt devs disable creating snapshot with sheepdog storage and raw image format. This patch allows creating snapshot (without --live flag for now) Vasiliy Tolstov (1): sheepdog: allow snapshot src/qemu/qemu_driver.c | 6 ++ 1 file

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2015-11-30 16:11 GMT+03:00 Peter Krempa : > That's the reason why it's forbidden. Nobody bothered to see if all the > operations actually work. Before removing the restrictions, all the > backend operations including everything to revert or delete the internal > snapshot need

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2015-11-30 14:02 GMT+03:00 Vasiliy Tolstov : > def->memory != VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL || when i'm remove this line --live flag for snapshot works fine (with sheepdog storage) What is the proper fix for this? Does i need to walk for each disk and check if

Re: [libvirt] [PATCH] sheepdog: allow snapshot

On Mon, Nov 30, 2015 at 14:02:18 +0300, Vasiliy Tolstov wrote: > 2015-11-30 13:45 GMT+03:00 Vasiliy Tolstov : > > In commit f7c1410b0ee5b878e81f2eddf86c609947a9b27c libvirt devs > > disable creating snapshot with sheepdog storage and raw image format. > > This patch allows

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2015-11-30 16:04 GMT+03:00 Peter Krempa : > > If you are doing an internal snapshot, the code can't be changed. > Internal snapshots do no allow the CPUs to run while taking it. Im try specify internal when doing snapshot, but in case of sheepdog and -memory state saved

Re: [libvirt] [PATCH] sheepdog: allow snapshot

2015-11-30 15:57 GMT+03:00 Vasiliy Tolstov : > > when i'm remove this line --live flag for snapshot works fine (with > sheepdog storage) > What is the proper fix for this? Does i need to walk for each disk and > check if storage is network and driver sheepdog? Also as i see

Re: [libvirt] [PATCH] sheepdog: allow snapshot

On Mon, Nov 30, 2015 at 16:03:22 +0300, Vasiliy Tolstov wrote: > 2015-11-30 15:57 GMT+03:00 Vasiliy Tolstov : > > > > when i'm remove this line --live flag for snapshot works fine (with > > sheepdog storage) > > What is the proper fix for this? Does i need to walk for each