Re: [libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-19 Thread lvroyce
Tested by:lvroyce test with cmd snapshot-create domain --disk-only ,patch works when qmp or hmp monitor accessible, Got trace below when issue cmd snapshot-delete domain --snapshotname name,no delvm/savevm in qmp, only delvm/savevm commands in hmp.Is this for future compability? 2011-09-19

Re: [libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-19 Thread Eric Blake
On 10/19/2011 03:25 AM, lvroyce wrote: Tested by:lvroyce test with cmd snapshot-create domain --disk-only ,patch works when qmp or hmp monitor accessible, Got trace below when issue cmd snapshot-delete domain --snapshotname name,no delvm/savevm in qmp, only delvm/savevm commands in hmp.Is this

Re: [libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-11 Thread Daniel Veillard
On Mon, Oct 10, 2011 at 03:35:42PM -0600, Eric Blake wrote: To date, disk snapshots worked by accident, as they were always using hmp fallback due to a typo in commit e702b5b not picking up on the (intentional) difference in command names between the two monitor protocols. *

Re: [libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-11 Thread Eric Blake
On 10/10/2011 11:53 PM, Daniel Veillard wrote: On Mon, Oct 10, 2011 at 03:35:42PM -0600, Eric Blake wrote: To date, disk snapshots worked by accident, as they were always using hmp fallback due to a typo in commit e702b5b not picking up on the (intentional) difference in command names between

[libvirt] [PATCH] snapshot: use correct qmp monitor command

2011-10-10 Thread Eric Blake
To date, disk snapshots worked by accident, as they were always using hmp fallback due to a typo in commit e702b5b not picking up on the (intentional) difference in command names between the two monitor protocols. * src/qemu/qemu_monitor_json.c (qemuMonitorJSONDiskSnapshot): Spell QMP command