Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2016 at 10:30:56AM +0100, Michal Privoznik wrote: > On 06.12.2016 13:49, Daniel P. Berrange wrote: > > When redoing the website we deleted the libvirtLogo.png file > > not remembering that the test driver screenshot API impl > > relied on it. > > > > Rather than having the test

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-07 Thread Michal Privoznik
On 06.12.2016 13:49, Daniel P. Berrange wrote: > When redoing the website we deleted the libvirtLogo.png file > not remembering that the test driver screenshot API impl > relied on it. > > Rather than having the test driver use the logo as a side > effect, give it its own dedicated image to use.

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-07 Thread Andrea Bolognani
On Tue, 2016-12-06 at 16:54 +, Daniel P. Berrange wrote: > > How about a pngcrush'd 640x480 solid color? Not only it would > > be way smaller, but we would also remove any possible confusion > > about it being an actual screenshot of a running domain. >  > I think it is desirable to have it

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 04:38:20PM +0100, Andrea Bolognani wrote: > On Tue, 2016-12-06 at 13:04 +, Daniel P. Berrange wrote: > > On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote: > > > > > > On Tue, Dec 06, 2016 at 12:49:21 +, Daniel Berrange wrote: > > > > > > > > When

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Peter Krempa
On Tue, Dec 06, 2016 at 16:38:20 +0100, Andrea Bolognani wrote: > On Tue, 2016-12-06 at 13:04 +, Daniel P. Berrange wrote: > > On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote: > > > > > > On Tue, Dec 06, 2016 at 12:49:21 +, Daniel Berrange wrote: > > > > > > > > When redoing

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Andrea Bolognani
On Tue, 2016-12-06 at 13:04 +, Daniel P. Berrange wrote: > On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote: > > > > On Tue, Dec 06, 2016 at 12:49:21 +, Daniel Berrange wrote: > > > > > > When redoing the website we deleted the libvirtLogo.png file > > > not remembering that

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote: > On Tue, Dec 06, 2016 at 12:49:21 +, Daniel Berrange wrote: > > When redoing the website we deleted the libvirtLogo.png file > > not remembering that the test driver screenshot API impl > > relied on it. > > > > Rather than having

Re: [libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Peter Krempa
On Tue, Dec 06, 2016 at 12:49:21 +, Daniel Berrange wrote: > When redoing the website we deleted the libvirtLogo.png file > not remembering that the test driver screenshot API impl > relied on it. > > Rather than having the test driver use the logo as a side > effect, give it its own

[libvirt] [PATCH] test: fix screenshot API impl

2016-12-06 Thread Daniel P. Berrange
When redoing the website we deleted the libvirtLogo.png file not remembering that the test driver screenshot API impl relied on it. Rather than having the test driver use the logo as a side effect, give it its own dedicated image to use. This is installed in /usr/share/libvirt/test-screenshot.png