Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-07 Thread Erik Skultety
On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > Validate @keycodes and sleep for @holdtime before successfully > returning. > > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety > src/test/test_driver.c | 40 > 1 file chang

Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-03 Thread Pavel Hrdina
On Mon, Jun 03, 2019 at 08:56:31AM +0200, Ján Tomko wrote: > On Mon, Jun 03, 2019 at 08:40:13AM +0200, Pavel Hrdina wrote: > > On Mon, Jun 03, 2019 at 08:23:57AM +0200, Erik Skultety wrote: > > > On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > > > > +for (i = 0; i < nkeycodes;

Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-02 Thread Ján Tomko
On Mon, Jun 03, 2019 at 08:40:13AM +0200, Pavel Hrdina wrote: On Mon, Jun 03, 2019 at 08:23:57AM +0200, Erik Skultety wrote: On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > +for (i = 0; i < nkeycodes; i++) { > +if (virKeycodeValueTranslate(codeset, codeset, keycodes

Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-02 Thread Erik Skultety
On Mon, Jun 03, 2019 at 08:40:13AM +0200, Pavel Hrdina wrote: > On Mon, Jun 03, 2019 at 08:23:57AM +0200, Erik Skultety wrote: > > On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > > > Validate @keycodes and sleep for @holdtime before successfully > > > returning. > > > > > > Signed

Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-02 Thread Pavel Hrdina
On Mon, Jun 03, 2019 at 08:23:57AM +0200, Erik Skultety wrote: > On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > > Validate @keycodes and sleep for @holdtime before successfully > > returning. > > > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 40

Re: [libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-02 Thread Erik Skultety
On Sat, Jun 01, 2019 at 02:46:56PM +0200, Ilias Stamatis wrote: > Validate @keycodes and sleep for @holdtime before successfully > returning. > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 40 > 1 file changed, 40 insertions(+) > > diff

[libvirt] [PATCH] test_driver: implement virDomainSendKey

2019-06-01 Thread Ilias Stamatis
Validate @keycodes and sleep for @holdtime before successfully returning. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f58a1da95..51ded