Re: [libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-16 Thread Ján Tomko
On Tue, Apr 16, 2019 at 11:27:44AM +0200, Ilias Stamatis wrote: Στις Τρί, 16 Απρ 2019 στις 2:00 π.μ., ο/η Cole Robinson έγραψε: On 4/9/19 6:16 AM, Ján Tomko wrote: > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: >> Implement testDomainGetTime by returning the current time. >>

Re: [libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-16 Thread Ilias Stamatis
Στις Τρί, 16 Απρ 2019 στις 2:00 π.μ., ο/η Cole Robinson έγραψε: > > On 4/9/19 6:16 AM, Ján Tomko wrote: > > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: > >> Implement testDomainGetTime by returning the current time. > >> > >> Signed-off-by: Ilias Stamatis > >> --- > >> I initi

Re: [libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-15 Thread Cole Robinson
On 4/9/19 6:16 AM, Ján Tomko wrote: > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: >> Implement testDomainGetTime by returning the current time. >> >> Signed-off-by: Ilias Stamatis >> --- >> I initially implemented this using clock_gettime, but Pavel suggested >> that this might

Re: [libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-09 Thread Pavel Hrdina
On Tue, Apr 09, 2019 at 12:16:22PM +0200, Ján Tomko wrote: > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: > > Implement testDomainGetTime by returning the current time. > > > > Signed-off-by: Ilias Stamatis > > --- > > I initially implemented this using clock_gettime, but Pavel

Re: [libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-09 Thread Ján Tomko
On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: Implement testDomainGetTime by returning the current time. Signed-off-by: Ilias Stamatis --- I initially implemented this using clock_gettime, but Pavel suggested that this might not be a good idea since it isn't a cross-platform f

[libvirt] [PATCH] test_driver: provide virDomainGetTime implementation

2019-04-07 Thread Ilias Stamatis
Implement testDomainGetTime by returning the current time. Signed-off-by: Ilias Stamatis --- I initially implemented this using clock_gettime, but Pavel suggested that this might not be a good idea since it isn't a cross-platform function. So I used virTimeMillisNow instead and set the nanosec