Re: [libvirt] [PATCH] tests: Xen: use qemu-system-i386 for emulator

2018-04-20 Thread Ján Tomko 

On Wed, Apr 11, 2018 at 01:25:10PM -0600, Jim Fehlig wrote:

Many of the old xm and sexpr test files used qemu-dm as the emulator.
Modern Xen systems no longer use the old, forked qemu-dm, instead
preferring the distro provided qemu or an "upstream" qemu that is
built when the Xen tools are built. This qemu is typically installed
in /usr/lib/xen/bin/qemu-system-i386.

The libxl test files already use /usr/lib/xen/bin/qemu-system-i386.
For consistency, change the old test files to use the same emulator

Signed-off-by: Jim Fehlig 
---

These config files can serve as examples too, so best not to
encourage use of outdated/deprecated config.



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: Xen: use qemu-system-i386 for emulator

2018-04-19 Thread Jim Fehlig 
Ping? It's a trivial patch that causes some test file churn, but IMO the 
consistency with other files and removal of deprecated config is worth it.


Regards,
Jim

On 04/11/2018 01:25 PM, Jim Fehlig wrote:

Many of the old xm and sexpr test files used qemu-dm as the emulator.
Modern Xen systems no longer use the old, forked qemu-dm, instead
preferring the distro provided qemu or an "upstream" qemu that is
built when the Xen tools are built. This qemu is typically installed
in /usr/lib/xen/bin/qemu-system-i386.

The libxl test files already use /usr/lib/xen/bin/qemu-system-i386.
For consistency, change the old test files to use the same emulator

Signed-off-by: Jim Fehlig 
---

These config files can serve as examples too, so best not to
encourage use of outdated/deprecated config.

  tests/sexpr2xmldata/sexpr2xml-fv-autoport.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-utc.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-utc.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-v2.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv-v2.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv.sexpr | 2 +-
  tests/sexpr2xmldata/sexpr2xml-fv.xml   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.sexpr| 2 +-
  tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.sexpr  | 2 +-
  tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml| 2 +-
  tests/sexpr2xmldata/sexpr2xml-vif-rate.sexpr   | 2 +-
  tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 2 +-
  tests/xmconfigdata/test-escape-paths.cfg   | 2 +-
  tests/xmconfigdata/test-escape-paths.xml   | 2 +-
  tests/xmconfigdata/test-fullvirt-default-feature.cfg   | 2 +-

[libvirt] [PATCH] tests: Xen: use qemu-system-i386 for emulator

2018-04-11 Thread Jim Fehlig 
Many of the old xm and sexpr test files used qemu-dm as the emulator.
Modern Xen systems no longer use the old, forked qemu-dm, instead
preferring the distro provided qemu or an "upstream" qemu that is
built when the Xen tools are built. This qemu is typically installed
in /usr/lib/xen/bin/qemu-system-i386.

The libxl test files already use /usr/lib/xen/bin/qemu-system-i386.
For consistency, change the old test files to use the same emulator

Signed-off-by: Jim Fehlig 
---

These config files can serve as examples too, so best not to
encourage use of outdated/deprecated config.

 tests/sexpr2xmldata/sexpr2xml-fv-autoport.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-dev-2nd-port.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-utc.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-utc.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-v2.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-v2.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv.sexpr | 2 +-
 tests/sexpr2xmldata/sexpr2xml-fv.xml   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.sexpr| 2 +-
 tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.sexpr  | 2 +-
 tests/sexpr2xmldata/sexpr2xml-pv-vfb-type-crash.xml| 2 +-
 tests/sexpr2xmldata/sexpr2xml-vif-rate.sexpr   | 2 +-
 tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 2 +-
 tests/xmconfigdata/test-escape-paths.cfg   | 2 +-
 tests/xmconfigdata/test-escape-paths.xml   | 2 +-
 tests/xmconfigdata/test-fullvirt-default-feature.cfg   | 2 +-
 tests/xmconfigdata/test-fullvirt-default-feature.xml   | 2 +-
 tests/xmconfigdata/test-fullvirt-force-hpet.cfg| 2 +-
 tests/xmconfigdata/test-fullvirt-force-hpet.xml| 2 +-
 tests/xmconfigdata/test-fullvirt-force-nohpet.cfg  | 2 +-