Re: [libvirt] [PATCH] tests: mock virRandomBits to make it endian stable

2018-08-05 Thread Eric Blake
On 08/02/2018 06:37 AM, Daniel P. Berrangé wrote: virRandomBits is implemented in terms of virRandomBytes. Although we mock virRandomBytes to give a stable value, this is not sufficient to make virRandomBits give a stable value. The result of virRandomBits will vary depending on endianness. Thus

Re: [libvirt] [PATCH] tests: mock virRandomBits to make it endian stable

2018-08-05 Thread Daniel P . Berrangé
On Thu, Aug 02, 2018 at 08:17:25AM -0500, Eric Blake wrote: > On 08/02/2018 06:37 AM, Daniel P. Berrangé wrote: > > virRandomBits is implemented in terms of virRandomBytes. Although we > > mock virRandomBytes to give a stable value, this is not sufficient to > > make virRandomBits give a stable

Re: [libvirt] [PATCH] tests: mock virRandomBits to make it endian stable

2018-08-05 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski and Tested-by: Boris Fiuczynski On 08/02/2018 01:37 PM, Daniel P. Berrangé wrote: virRandomBits is implemented in terms of virRandomBytes. Although we mock virRandomBytes to give a stable value, this is not sufficient to make virRandomBits give a stable value.

[libvirt] [PATCH] tests: mock virRandomBits to make it endian stable

2018-08-02 Thread Daniel P . Berrangé
virRandomBits is implemented in terms of virRandomBytes. Although we mock virRandomBytes to give a stable value, this is not sufficient to make virRandomBits give a stable value. The result of virRandomBits will vary depending on endianness. Thus we mock virRandomBits to return a stable value