[libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Philipp Hahn
Hello, I find parsing the output of ls -l very suspect and fragile, since its output heaviely depends on the environment: SELinux, ACLs, locale. Perhaps using /usr/bin/stat would be better, but I don't know how available /usr/bin/stat is on non-Linux-platforms (on my Debian system it's in

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Eric Blake
On 05/31/2012 05:57 AM, Philipp Hahn wrote: Hello, I find parsing the output of ls -l very suspect and fragile, As do I. since its output heaviely depends on the environment: SELinux, ACLs, That only affects the 11th character, which we are stripping. locale. That affects the date

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Eric Blake
On 05/31/2012 03:02 AM, Martin Kletzander wrote: This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
On 05/31/2012 04:49 PM, Eric Blake wrote: On 05/31/2012 03:02 AM, Martin Kletzander wrote: This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4