Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-14 Thread Andreas Krebbel
On 10/07/2016 12:43 PM, Jiri Denemark wrote: > GCC on s390 complains > > util/virconf.c: In function 'virConfGetValueSizeT': > util/virconf.c:1220:9: error: format '%zu' expects argument of type > 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-14 Thread Andreas Krebbel
On 10/07/2016 12:43 PM, Jiri Denemark wrote: > GCC on s390 complains > > util/virconf.c: In function 'virConfGetValueSizeT': > util/virconf.c:1220:9: error: format '%zu' expects argument of type > 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Paul Eggert
On 10/13/2016 12:14 PM, Eric Blake wrote: I think a configure test based on -Werror=format would be sufficient What we have now should work for GCC 2.0 and later, whereas -Werror=format is a much-newer GCC feature and so would be less portable. if they are using some other compiler, then

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Eric Blake
On 10/13/2016 01:50 PM, Eric Blake wrote: > On 10/13/2016 01:23 PM, Paul Eggert wrote: >> On 10/13/2016 06:36 AM, Eric Blake wrote: >>> That's a bug in s390's system headers. Gnulib should be taught to work >>> around it. >> >> Although this bug was reported fixed in glibc 2.20; see >> >>

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Eric Blake
On 10/13/2016 01:23 PM, Paul Eggert wrote: > On 10/13/2016 06:36 AM, Eric Blake wrote: >> That's a bug in s390's system headers. Gnulib should be taught to work >> around it. > > Although this bug was reported fixed in glibc 2.20; see > > https://sourceware.org/bugzilla/show_bug.cgi?id=16712 >

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Paul Eggert
On 10/13/2016 06:36 AM, Eric Blake wrote: That's a bug in s390's system headers. Gnulib should be taught to work around it. Although this bug was reported fixed in glibc 2.20; see https://sourceware.org/bugzilla/show_bug.cgi?id=16712 the Gnulib manual says the bug is still in glibc 2.24;

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Eric Blake
On 10/07/2016 05:43 AM, Jiri Denemark wrote: > GCC on s390 complains > > util/virconf.c: In function 'virConfGetValueSizeT': > util/virconf.c:1220:9: error: format '%zu' expects argument of type > 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] > That's a bug in s390's system

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-13 Thread Jiri Denemark
Hi. On Fri, Oct 07, 2016 at 13:36:21 +0200, Christian Borntraeger wrote: > On 10/07/2016 12:43 PM, Jiri Denemark wrote: > > GCC on s390 complains > > > > util/virconf.c: In function 'virConfGetValueSizeT': > > util/virconf.c:1220:9: error: format '%zu' expects argument of type > > 'size_t', but

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-07 Thread Christian Borntraeger
On 10/07/2016 12:43 PM, Jiri Denemark wrote: > GCC on s390 complains > > util/virconf.c: In function 'virConfGetValueSizeT': > util/virconf.c:1220:9: error: format '%zu' expects argument of type > 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] Interesting, we have never seen

[libvirt] [PATCH] util: Fix build on s390

2016-10-07 Thread Jiri Denemark
GCC on s390 complains util/virconf.c: In function 'virConfGetValueSizeT': util/virconf.c:1220:9: error: format '%zu' expects argument of type 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] Signed-off-by: Jiri Denemark --- src/util/virconf.c | 2 +- 1