Re: [libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-18 Thread Alex Jia
On 08/16/2013 07:42 PM, Eric Blake wrote: On 08/16/2013 01:47 AM, Alex Jia wrote: This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch,

[libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-16 Thread Alex Jia
This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch, libvirtd no crash and can get a expected error Failed to parse nodeset. How to reproduce?

Re: [libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-16 Thread Peter Krempa
On 08/16/13 09:47, Alex Jia wrote: This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch, libvirtd no crash and can get a expected error Failed

Re: [libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-16 Thread Eric Blake
On 08/16/2013 01:47 AM, Alex Jia wrote: This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch, libvirtd no crash and can get a expected error