Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-05 Thread Peter Krempa
On Tue, Jul 31, 2018 at 15:55:28 +0100, Daniel Berrange wrote: > The jansson and json-glib libraries both export symbols with a json_ > name prefix and json_object_iter_next() clashes between them. > > Unfortunately json_glib is linked in by GTK, so any app using GTK and > libvirt will get a

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-05 Thread Ján Tomko
On Tue, Jul 31, 2018 at 03:55:28PM +0100, Daniel P. Berrangé wrote: The jansson and json-glib libraries both export symbols with a json_ name prefix and json_object_iter_next() clashes between them. Unfortunately json_glib is linked in by GTK, so any app using GTK and json-glib libvirt will

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-05 Thread Eric Blake
On 07/31/2018 09:55 AM, Daniel P. Berrangé wrote: The jansson and json-glib libraries both export symbols with a json_ name prefix and json_object_iter_next() clashes between them. Unfortunately json_glib is linked in by GTK, so any app using GTK and libvirt will get a clash, resulting in SEGV.

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-05 Thread Andrea Bolognani
On Tue, 2018-07-31 at 15:55 +0100, Daniel P. Berrangé wrote: [...] > +# We dlopen() it so need an explicit dep > +Requires: libjansson.so.4()(64bit) Wouldn't requiring jansson be better here? I don't think many people are running libvirt on 32-bit machines these days, but the (64bit) part still

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-05 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180731145528.9845-1-berra...@redhat.com Subject: [libvirt] [PATCH] util: avoid symbol clash between json libraries === TEST SCRIPT BEGIN === #!/bin/bash

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-08-01 Thread Daniel P . Berrangé
On Wed, Aug 01, 2018 at 09:31:49AM +0200, Peter Krempa wrote: > On Tue, Jul 31, 2018 at 15:55:28 +0100, Daniel Berrange wrote: > > The jansson and json-glib libraries both export symbols with a json_ > > name prefix and json_object_iter_next() clashes between them. > > > > Unfortunately json_glib

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-07-31 Thread Daniel P . Berrangé
On Tue, Jul 31, 2018 at 11:28:02AM -0500, Eric Blake wrote: > On 07/31/2018 09:55 AM, Daniel P. Berrangé wrote: > > The jansson and json-glib libraries both export symbols with a json_ > > name prefix and json_object_iter_next() clashes between them. > > > > Unfortunately json_glib is linked in

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-07-31 Thread Daniel P . Berrangé
On Tue, Jul 31, 2018 at 06:07:20PM +0200, Ján Tomko wrote: > On Tue, Jul 31, 2018 at 03:55:28PM +0100, Daniel P. Berrangé wrote: > > The jansson and json-glib libraries both export symbols with a json_ > > name prefix and json_object_iter_next() clashes between them. > > > > Unfortunately

Re: [libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-07-31 Thread Daniel P . Berrangé
On Tue, Jul 31, 2018 at 05:57:21PM +0200, Andrea Bolognani wrote: > On Tue, 2018-07-31 at 15:55 +0100, Daniel P. Berrangé wrote: > [...] > > +# We dlopen() it so need an explicit dep > > +Requires: libjansson.so.4()(64bit) > > Wouldn't requiring jansson be better here? I don't think many > people

[libvirt] [PATCH] util: avoid symbol clash between json libraries

2018-07-31 Thread Daniel P . Berrangé
The jansson and json-glib libraries both export symbols with a json_ name prefix and json_object_iter_next() clashes between them. Unfortunately json_glib is linked in by GTK, so any app using GTK and libvirt will get a clash, resulting in SEGV. This also affects the NSS module provided by