Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Daniel P . Berrangé
On Wed, Aug 21, 2019 at 03:30:05AM -0700, Sage Imel wrote: > No objection, thanks for catching that. This is now pushed, thanks for your contribution. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Sage Imel
No objection, thanks for catching that. -- Sage Imel Lead Linux/Unix System Administrator Maseeh College of Engineering and Computer Science Computer Action Team supp...@cat.pdx.edu - (503) 725-5420 On Wed, Aug 21, 2019 at 3:27 AM Daniel P. Berrangé wrote: > On Thu, Aug 15, 2019 at

Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Daniel P . Berrangé
On Thu, Aug 15, 2019 at 02:41:40PM -0700, Sage Imel wrote: > The current version of get_autostart seg faults. This patch > correctly passes a pointer to an int to virDomainGetAutostart > and returns a result based on the value of that int > > Signed-off-by: sage Imel Jan points out the

Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Daniel P . Berrangé
On Wed, Aug 21, 2019 at 12:22:47PM +0200, Ján Tomko wrote: > On Wed, Aug 21, 2019 at 11:01:41AM +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 15, 2019 at 02:22:52PM -0700, Sage Imel wrote: > > > --- > > > src/domain.rs | 7 --- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > >

Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Ján Tomko
On Wed, Aug 21, 2019 at 11:01:41AM +0100, Daniel P. Berrangé wrote: On Thu, Aug 15, 2019 at 02:22:52PM -0700, Sage Imel wrote: --- src/domain.rs | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) The change looks good, however, we need contributors to assert compliance with the

Re: [libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-21 Thread Daniel P . Berrangé
On Thu, Aug 15, 2019 at 02:22:52PM -0700, Sage Imel wrote: > --- > src/domain.rs | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) The change looks good, however, we need contributors to assert compliance with the Developer Certificate of Origin:

[libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-16 Thread Sage Imel
--- src/domain.rs | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/domain.rs b/src/domain.rs index 11ecb3c..acb9e6e 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -136,7 +136,7 @@ extern "C" { fn virDomainGetHostname(ptr: sys::virDomainPtr, flags:

[libvirt] [PATCH] virDomainGetAutostart takes a pointer that it writes the output value to

2019-08-15 Thread Sage Imel
The current version of get_autostart seg faults. This patch correctly passes a pointer to an int to virDomainGetAutostart and returns a result based on the value of that int Signed-off-by: sage Imel --- src/domain.rs | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git