Re: [libvirt] [PATCH] virrandom: Avoid undefined behaviour in virRandomBits

2018-08-06 Thread Daniel P . Berrangé
On Thu, Aug 02, 2018 at 09:35:49AM +0200, Michal Privoznik wrote: > If nbits is 64 (or greater) then shifting 1ULL left is undefined. > > Signed-off-by: Michal Privoznik > --- > src/util/virrandom.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[libvirt] [PATCH] virrandom: Avoid undefined behaviour in virRandomBits

2018-08-05 Thread Michal Privoznik
If nbits is 64 (or greater) then shifting 1ULL left is undefined. Signed-off-by: Michal Privoznik --- src/util/virrandom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virrandom.c b/src/util/virrandom.c index 3c011a8615..7915f6531e 100644 ---