Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-13 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180810112233.44540-1-i...@conquex.com Subject: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable === TEST SCRIPT BEGIN === #!/bin/bash

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-13 Thread Roman Bogorodskiy
Ivan Mishonov wrote: > On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote: > > > On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: > >>Ivan Mishonov wrote: > >> > >>> Yes, that makes sense. I'll try to find some time next week to redo my > >>> code and send another patch.

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-13 Thread Ivan Mishonov
On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote: On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: Ivan Mishonov wrote: Yes, that makes sense. I'll try to find some time next week to redo my code and send another patch. Since my time for working on libvirt is very

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-13 Thread Daniel P . Berrangé
On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: > Ivan Mishonov wrote: > > > Yes, that makes sense. I'll try to find some time next week to redo my > > code and send another patch. Since my time for working on libvirt is > > very limited can you confirm that the LPC

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-12 Thread Roman Bogorodskiy
Ivan Mishonov wrote: > Yes, that makes sense. I'll try to find some time next week to redo my > code and send another patch. Since my time for working on libvirt is > very limited can you confirm that the LPC configuration should look like > this: > >    >    >    This looks

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 06:36:46PM +0300, Ivan Mishonov wrote: > Yes, that makes sense. I'll try to find some time next week to redo my code > and send another patch. Since my time for working on libvirt is very limited > can you confirm that the LPC configuration should look like this: > >    >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
Yes, that makes sense. I'll try to find some time next week to redo my code and send another patch. Since my time for working on libvirt is very limited can you confirm that the LPC configuration should look like this:          Also can you send me an example of how you imagine the

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 06:11:57PM +0300, Ivan Mishonov wrote: > I'd like to hear Roman's opinion on this too since he wrote the initial > implementation. As for the command line arguments I was looking at > since it's doing exactly the same thing and I thought it > would be nice to be consistent

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
I'd like to hear Roman's opinion on this too since he wrote the initial implementation. As for the command line arguments I was looking at since it's doing exactly the same thing and I thought it would be nice to be consistent with it Regards, Ivan On 08/10/2018 05:57 PM, Daniel P. Berrangé

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 05:47:40PM +0300, Ivan Mishonov wrote: > Yes, this is totally doable. I just don't know if it's a good idea to add a > new device type specifically for bhyve LPC and nothing else. Even if we do > it like this I'll still have to send another patch including the bhyve XML >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
Yes, this is totally doable. I just don't know if it's a good idea to add a new device type specifically for bhyve LPC and nothing else. Even if we do it like this I'll still have to send another patch including the bhyve XML namespace as we need to be able to pass extra command line options

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 03:41:09PM +0300, Ivan Mishonov wrote: > This is how it's described in bhyve(8). Basically you need to configure one > for each bhyve VM. Otherwise the VM won't boot. I'm not sure if there's an > equivalent device in other Hypervisors. I've used KVM for quite some time >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
This is how it's described in bhyve(8). Basically you need to configure one for each bhyve VM. Otherwise the VM won't boot. I'm not sure if there's an equivalent device in other Hypervisors. I've used KVM for quite some time and didn't need to configure anything similar lpc LPC

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 03:20:06PM +0300, Ivan Mishonov wrote: > The problem is that LPC is not defined as a device in the XML. Is there a > device type we can use for the LPC slot configuration similarly to disk, NIC > etc? I couldn't find one, but I'm not that familiar with the code so maybe >

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
The problem is that LPC is not defined as a device in the XML. Is there a device type we can use for the LPC slot configuration similarly to disk, NIC etc? I couldn't find one, but I'm not that familiar with the code so maybe I'm missing something Regards, Ivan On 08/10/2018 02:34 PM, Daniel

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 02:22:32PM +0300, Ivan Mishonov wrote: > Windows UEFI guests didn't have working keyboard input through VNC > when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 > for UEFI guests. Borrowed most of the code from the qemu:commandline > implementation and made

[libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
Windows UEFI guests didn't have working keyboard input through VNC when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 for UEFI guests. Borrowed most of the code from the qemu:commandline implementation and made LPC slot number configurable e.g. Ivan Mishonov (1): bhyve: Make