On 8/1/19 5:00 PM, Daniel P. Berrangé wrote:
>
>
Very nice cleanup, which also makes NSS library smaller in size (I mean
those .so.2 files).
I've found some mem leaks and mis-alignments, though. Please squash this
into respective patches:
diff --git a/tools/nss/libvirt_nss.c
As previously discussed, it is desirable to move libvirt to a model
where we abort-on-OOM, possibly making use of glib2.
This would be good for libvirt in general, but it is bad for a
couple of libvirt addons.
The virt-login-shell setuid program would be ok with abort-on-OOM,
but absolutely can