Re: [libvirt] [PATCH 01/20] bhyve: Use virDomainObjListFindBy{UUID|ID}Ref

2018-03-13 Thread John Ferlan
On 03/13/2018 12:44 PM, Marc Hartmayer wrote: > On Tue, Mar 13, 2018 at 01:39 PM +0100, John Ferlan > wrote: >> On 03/13/2018 03:44 AM, Marc Hartmayer wrote: >>> On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan >>> wrote: For

Re: [libvirt] [PATCH 01/20] bhyve: Use virDomainObjListFindBy{UUID|ID}Ref

2018-03-13 Thread Marc Hartmayer
On Tue, Mar 13, 2018 at 01:39 PM +0100, John Ferlan wrote: > On 03/13/2018 03:44 AM, Marc Hartmayer wrote: >> On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan >> wrote: >>> For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and >>>

Re: [libvirt] [PATCH 01/20] bhyve: Use virDomainObjListFindBy{UUID|ID}Ref

2018-03-13 Thread John Ferlan
On 03/13/2018 03:44 AM, Marc Hartmayer wrote: > On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan > wrote: >> For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and >> bhyveDomainLookupByID let's return a locked and referenced >> @vm object so that callers can then use

Re: [libvirt] [PATCH 01/20] bhyve: Use virDomainObjListFindBy{UUID|ID}Ref

2018-03-13 Thread Marc Hartmayer
On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan wrote: > For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and > bhyveDomainLookupByID let's return a locked and referenced > @vm object so that callers can then use the common and more > consistent virDomainObjEndAPI in

[libvirt] [PATCH 01/20] bhyve: Use virDomainObjListFindBy{UUID|ID}Ref

2018-03-09 Thread John Ferlan
For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and bhyveDomainLookupByID let's return a locked and referenced @vm object so that callers can then use the common and more consistent virDomainObjEndAPI in order to handle cleanup rather than needing to know that the returned object is locked and