Re: [libvirt] [PATCH 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

2018-02-12 Thread Peter Krempa
On Mon, Feb 12, 2018 at 17:19:24 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-12 at 16:40 +0100, Peter Krempa wrote: > > > @@ -6865,6 +6865,14 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr > > > disk, > > > CHECK_EQ(src->readonly, "readonly", true); > > > CHECK_EQ(src->shared,

Re: [libvirt] [PATCH 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

2018-02-12 Thread Andrea Bolognani
On Mon, 2018-02-12 at 16:40 +0100, Peter Krempa wrote: > > @@ -6865,6 +6865,14 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr > > disk, > > CHECK_EQ(src->readonly, "readonly", true); > > CHECK_EQ(src->shared, "shared", true); > > > > +if (!virStoragePRDefIsEqual(disk->src->pr

Re: [libvirt] [PATCH 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

2018-02-12 Thread Peter Krempa
On Thu, Jan 18, 2018 at 17:04:34 +0100, Michal Privoznik wrote: > Couple of reasons for that: > > a) there's no monitor command to change path where the pr-helper > connects to, or > b) there's no monitor command to introduce a new pr-helper for a > disk that already exists. > > Signed-off-by: Mi

[libvirt] [PATCH 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

2018-01-18 Thread Michal Privoznik
Couple of reasons for that: a) there's no monitor command to change path where the pr-helper connects to, or b) there's no monitor command to introduce a new pr-helper for a disk that already exists. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c