Re: [libvirt] [PATCH 03/20] libxl: Properly cleanup after libxlDomObjFromDomain

2018-03-16 Thread Jim Fehlig
On 03/11/2018 08:13 PM, Jim Fehlig wrote: On 03/09/2018 09:47 AM, John Ferlan wrote: Commit id '9ac945078' altered libxlDomObjFromDomain to return a locked *and* ref counted object for some specific purposes; however, it neglected to alter all the consumers of the helper to use

Re: [libvirt] [PATCH 03/20] libxl: Properly cleanup after libxlDomObjFromDomain

2018-03-12 Thread John Ferlan
On 03/11/2018 10:13 PM, Jim Fehlig wrote: > On 03/09/2018 09:47 AM, John Ferlan wrote: >> Commit id '9ac945078' altered libxlDomObjFromDomain to return >> a locked *and* ref counted object for some specific purposes; >> however, it neglected to alter all the consumers of the helper >> to use

Re: [libvirt] [PATCH 03/20] libxl: Properly cleanup after libxlDomObjFromDomain

2018-03-11 Thread Jim Fehlig
On 03/09/2018 09:47 AM, John Ferlan wrote: Commit id '9ac945078' altered libxlDomObjFromDomain to return a locked *and* ref counted object for some specific purposes; however, it neglected to alter all the consumers of the helper to use virDomainObjEndAPI thus leaving many objects with extra ref

[libvirt] [PATCH 03/20] libxl: Properly cleanup after libxlDomObjFromDomain

2018-03-09 Thread John Ferlan
Commit id '9ac945078' altered libxlDomObjFromDomain to return a locked *and* ref counted object for some specific purposes; however, it neglected to alter all the consumers of the helper to use virDomainObjEndAPI thus leaving many objects with extra ref counts. The two consumers for