Re: [libvirt] [PATCH 03/40] Remove pointless GET_PRIVATE macro from Xen driver

2013-05-03 Thread Jim Fehlig
Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The Xen driver uses a macro GET_PRIVATE as a supposed shorthand > for 'xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) (conn)->privateData'. > It does not in fact save any lines of code, and obscures what is > happening. Remove it, sinc

[libvirt] [PATCH 03/40] Remove pointless GET_PRIVATE macro from Xen driver

2013-05-02 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The Xen driver uses a macro GET_PRIVATE as a supposed shorthand for 'xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) (conn)->privateData'. It does not in fact save any lines of code, and obscures what is happening. Remove it, since it adds no value. Signed-off-by: D