Re: [libvirt] [PATCH 03/75] access: Drop virAsprintf() and virAsprintfQuiet() retval checking

2019-10-22 Thread Michal Privoznik
On 10/22/19 4:09 PM, Daniel P. Berrangé wrote: On Tue, Oct 22, 2019 at 03:57:07PM +0200, Michal Privoznik wrote: These functions can't fail really. Drop checking of their retval then. These are declared G_GNUC_WARN_UNUSED_RESULT so this will surely result in a broken build when bisecting.

Re: [libvirt] [PATCH 03/75] access: Drop virAsprintf() and virAsprintfQuiet() retval checking

2019-10-22 Thread Daniel P . Berrangé
On Tue, Oct 22, 2019 at 03:57:07PM +0200, Michal Privoznik wrote: > These functions can't fail really. Drop checking of their retval > then. These are declared G_GNUC_WARN_UNUSED_RESULT so this will surely result in a broken build when bisecting. When I added the abort-on-OOM logic I

[libvirt] [PATCH 03/75] access: Drop virAsprintf() and virAsprintfQuiet() retval checking

2019-10-22 Thread Michal Privoznik
These functions can't fail really. Drop checking of their retval then. Signed-off-by: Michal Privoznik --- src/access/viraccessdriverpolkit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c index