Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-10-01 Thread Andrea Bolognani
On Tue, 2019-10-01 at 10:12 -0400, Laine Stump wrote: > On 9/30/19 1:35 PM, Andrea Bolognani wrote: > > Writing a check that compares the situation before a commit and > > after it is not as easy as a point-in-time check. > > Not all that bad though - just examine the lines that start with + Fair

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-10-01 Thread Laine Stump
On 9/30/19 1:35 PM, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:13 -0400, Laine Stump wrote: On 9/30/19 10:05 AM, Andrea Bolognani wrote: I see your point about backports being more painful when you have a bunch of unrelated changes mixed in, but I would still prefer if we converted everyt

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Andrea Bolognani
On Mon, 2019-09-30 at 13:13 -0400, Laine Stump wrote: > On 9/30/19 10:05 AM, Andrea Bolognani wrote: > > I see your point about backports being more painful when you have > > a bunch of unrelated changes mixed in, but I would still prefer if > > we converted everything at once and at the same time

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Laine Stump
On 9/30/19 10:05 AM, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: Agreed, for now let's keep all the wrappers but eventually we can r

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Andrea Bolognani
On Mon, 2019-09-30 at 16:34 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 30, 2019 at 05:24:00PM +0200, Peter Krempa wrote: > > On Mon, Sep 30, 2019 at 16:10:11 +0100, Daniel Berrange wrote: > > > It don't be in a half-done state forever. We can let things be converted > > > incrementally over the

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 05:17:32PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-30 at 15:53 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > > > I see your point about backports being more painful when you have > > > a bunch of unrelated c

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 05:24:00PM +0200, Peter Krempa wrote: > On Mon, Sep 30, 2019 at 16:10:11 +0100, Daniel Berrange wrote: > > On Mon, Sep 30, 2019 at 05:03:47PM +0200, Peter Krempa wrote: > > > On Mon, Sep 30, 2019 at 15:53:35 +0100, Daniel Berrange wrote: > > > > On Mon, Sep 30, 2019 at 04:05

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Peter Krempa
On Mon, Sep 30, 2019 at 16:10:11 +0100, Daniel Berrange wrote: > On Mon, Sep 30, 2019 at 05:03:47PM +0200, Peter Krempa wrote: > > On Mon, Sep 30, 2019 at 15:53:35 +0100, Daniel Berrange wrote: > > > On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > > > > On Mon, 2019-09-30 at 13:

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Andrea Bolognani
On Mon, 2019-09-30 at 15:53 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > > I see your point about backports being more painful when you have > > a bunch of unrelated changes mixed in, but I would still prefer if > > we converted everything a

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 05:03:47PM +0200, Peter Krempa wrote: > On Mon, Sep 30, 2019 at 15:53:35 +0100, Daniel Berrange wrote: > > On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > > > On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: > > > > On Mon, Sep 30, 2019 at 02:

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Peter Krempa
On Mon, Sep 30, 2019 at 15:53:35 +0100, Daniel Berrange wrote: > On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: > > > > On Mon, 2019-09-30 at 1

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 04:05:57PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: > > > On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: > > > > Agreed, for now let's keep all

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Andrea Bolognani
On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: > > > Agreed, for now let's keep all the wrappers but eventually we can remove > > > them to make the code clea

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > On Fri, Sep 27, 2019 at 18:17:28 +0100, Daniel Berrange wrote: > > Replace use of the gnulib base64 module with glib's own base64 API family. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > bootstrap.conf|

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: > > On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > > > > On Mon, Sep 30, 2019 at 09:0

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 02:21:46PM +0200, Peter Krempa wrote: > On Mon, Sep 30, 2019 at 13:19:41 +0100, Daniel Berrange wrote: > > On Mon, Sep 30, 2019 at 02:03:53PM +0200, Peter Krempa wrote: > > > On Mon, Sep 30, 2019 at 13:56:06 +0200, Pavel Hrdina wrote: > > > > On Mon, Sep 30, 2019 at 12:45:56

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Peter Krempa
On Mon, Sep 30, 2019 at 13:19:41 +0100, Daniel Berrange wrote: > On Mon, Sep 30, 2019 at 02:03:53PM +0200, Peter Krempa wrote: > > On Mon, Sep 30, 2019 at 13:56:06 +0200, Pavel Hrdina wrote: > > > On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Sep 30, 2019 at 01

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 02:03:53PM +0200, Peter Krempa wrote: > On Mon, Sep 30, 2019 at 13:56:06 +0200, Pavel Hrdina wrote: > > On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > > > > On Mon, Sep 30, 2019 at 09:

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Andrea Bolognani
On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: > On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > > > On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > > > > On Fri, Sep 27, 2019 at 18:17:28

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Peter Krempa
On Mon, Sep 30, 2019 at 13:56:06 +0200, Pavel Hrdina wrote: > On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > > > On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > > > > On Fri, Sep 27, 2019 at 18:

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Pavel Hrdina
On Mon, Sep 30, 2019 at 12:45:56PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > > On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > > > On Fri, Sep 27, 2019 at 18:17:28 +0100, Daniel Berrange wrote: > > > > Replace use of the gnuli

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 01:41:52PM +0200, Pavel Hrdina wrote: > On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > > On Fri, Sep 27, 2019 at 18:17:28 +0100, Daniel Berrange wrote: > > > Replace use of the gnulib base64 module with glib's own base64 API family. > > > > > > Signed-off-b

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Pavel Hrdina
On Mon, Sep 30, 2019 at 09:02:36AM +0200, Peter Krempa wrote: > On Fri, Sep 27, 2019 at 18:17:28 +0100, Daniel Berrange wrote: > > Replace use of the gnulib base64 module with glib's own base64 API family. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > bootstrap.conf|

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Peter Krempa
On Fri, Sep 27, 2019 at 18:17:28 +0100, Daniel Berrange wrote: > Replace use of the gnulib base64 module with glib's own base64 API family. > > Signed-off-by: Daniel P. Berrangé > --- > bootstrap.conf| 1 - > src/conf/virsecretobj.c | 38 +++

[libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-27 Thread Daniel P . Berrangé
Replace use of the gnulib base64 module with glib's own base64 API family. Signed-off-by: Daniel P. Berrangé --- bootstrap.conf| 1 - src/conf/virsecretobj.c | 38 +++ src/libvirt_private.syms | 1 - src/libxl/libxl_conf.c